• tatterdemalion@programming.dev
    link
    fedilink
    arrow-up
    0
    ·
    edit-2
    7 months ago

    You don’t need to restart your LSP to switch to a new branch. You also don’t need an LSP to find the types.

    Even with all of these issues aside, I can’t think of the last time I was reviewing a PR where it wasn’t clear from context what the types were, or they were irrelevant.

    • sudo@programming.dev
      link
      fedilink
      arrow-up
      0
      ·
      7 months ago

      wth is your position then? If I can know the types from just looking at the code then it must have adequate type annotations and none of this matters. If I can’t tell the types and I have to pull the code locally to figure it out then I’m not starting the review on a good foot.

      I think people here are thinking about type inference in a very local scope and not at a public function level which I understood the author to be complaining about.