trclst@lemmy.ml to Linux@lemmy.ml · 11 months agoI FIXED AMD's Preferred Core Linux patch to FINALLY work for HIGHER BOOST and PERFORMANCE !www.youtube.comexternal-linkmessage-square19fedilinkarrow-up1202arrow-down111
arrow-up1191arrow-down1external-linkI FIXED AMD's Preferred Core Linux patch to FINALLY work for HIGHER BOOST and PERFORMANCE !www.youtube.comtrclst@lemmy.ml to Linux@lemmy.ml · 11 months agomessage-square19fedilink
minus-squareNoXPhasma@lemmy.worldlinkfedilinkarrow-up7·edit-211 months agoIt’s not just random, it simply does not even work. Because they set this: +/*Preferred Core featue is supported*/ +static bool prefcore = true; And later in the code they do the if condition wrong: + if (prefcore) + WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD); + else + WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1)); if should look like this: + if (prefcore) + WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1)); + else + WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);
minus-squareOlissipo@programming.devlinkfedilinkEnglisharrow-up1·edit-211 months agoI don’t know if we’re discussing semantics. A performance score is attributed, and before the fix their scores were all 166. It doesn’t work, as you said. So the consequence is the preferred core being “random”, isn’t it?
It’s not just random, it simply does not even work. Because they set this:
+/*Preferred Core featue is supported*/ +static bool prefcore = true;And later in the code they do the if condition wrong:
+ if (prefcore) + WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD); + else + WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1));if should look like this:
+ if (prefcore) + WRITE_ONCE(cpudata->highest_perf, AMD_CPPC_HIGHEST_PERF(cap1)); + else + WRITE_ONCE(cpudata->highest_perf, AMD_PSTATE_PREFCORE_THRESHOLD);I don’t know if we’re discussing semantics. A performance score is attributed, and before the fix their scores were all 166. It doesn’t work, as you said. So the consequence is the preferred core being “random”, isn’t it?