• realharo@lemm.ee
    link
    fedilink
    arrow-up
    27
    arrow-down
    1
    ·
    edit-2
    1 year ago

    Anything for indent (barely matters, as long as the editor forces it to stay consistent), and fuck alignment, just put things on a new line.

    • z3bra@lemmy.sdf.org
      link
      fedilink
      arrow-up
      17
      arrow-down
      2
      ·
      edit-2
      1 year ago
      struct Ident arr = [
      {
      .id
      = 0,
      .name
      = "Bob",
      .pubkey
      = "",
      .privkey
      = ""
      },
      {
      .id
      = 1,
      .name
      = "Alice",
      .pubkey
      = "",
      .privkey
      = ""
      }
      ];
      
      • realharo@lemm.ee
        link
        fedilink
        arrow-up
        14
        arrow-down
        1
        ·
        edit-2
        1 year ago

        Not like that, lol

        Just saying, instead of this monstrosity

        CreateOrderRequest(user,
                           productDetails,
                           pricingCalculator,
                           order => order.internalNumber)
        

        Just use

        CreateOrderRequest(
            user,
            ...
        

        Putting the first argument on a separate line.

        Same if you have an if using a bunch of and (one condition per line, first one on a new line instead of same line as the if) and similar situations.

        • z3bra@lemmy.sdf.org
          link
          fedilink
          arrow-up
          7
          arrow-down
          1
          ·
          edit-2
          1 year ago

          When I talk about alignment it’s not about function arguments, but values, “=” signs and such. You simply cannot use tabs for that because alignment must be fixed and indentation independent:

          CreateOrderRequest(
              user,
              productDetails     => order.detail,
              pricingCalculator  => DEFAULT_CALCULATOR,
              order              => order.internalNumber)
          
          • realharo@lemm.ee
            link
            fedilink
            arrow-up
            9
            ·
            edit-2
            1 year ago

            I normally avoid that too, I find it hurts readability more than helps, plus a proper IDE will separate it with color anyway.

            But yeah, the newline comment doesn’t apply to this.

            • z3bra@lemmy.sdf.org
              link
              fedilink
              arrow-up
              1
              ·
              1 year ago

              To each their own indeed. But my rule of thumb is: only use tabs when there’s no other character before it (aka, start of line).

          • catastrophicblues@lemmy.ca
            link
            fedilink
            arrow-up
            2
            ·
            1 year ago

            Yeah I agree I don’t find alignment very useful. It’s more work for dubious benefit, and god forbid you change one of the lines.

        • Lmaydev@programming.dev
          link
          fedilink
          arrow-up
          7
          arrow-down
          1
          ·
          1 year ago

          People seem to have a real issue with using new lines and I’ve never quite understod why.

          It feels like a lot of those people are using notepad like applications instead of coding focused ones with collapsible regions etc.

    • milo128@lemm.ee
      link
      fedilink
      arrow-up
      1
      arrow-down
      1
      ·
      1 year ago

      seconded on not aligning things. its the whole source of the problem in the first place and doesnt even serve a purpose

      • MajorHavoc@lemmy.world
        link
        fedilink
        arrow-up
        1
        ·
        1 year ago

        It does help with reducing thrashing between edits in git diffs. Or rather, opinionated autoformatters do, which is the only reason I bother with alignment.