• 0 Posts
  • 10 Comments
Joined 1 year ago
cake
Cake day: September 27th, 2023

help-circle




  • I generally agree and like this strategy, but to add to the other comment about catching reimplemented code, there’s just some code quality reviewing that cannot be done by automating tooling right now.

    Some scenarios come to mind:

    • code is written in a brittle fashion, especially with external data, where it’s difficult to unit test every type of input; generally you might catch improper assumptions about the data in the code
    • code reimplements a more battle tested functionality, or uses a library no longer maintained or is possibly unreliable
    • code that the test coverage unintentionally misses due to code being located outside of the test path
    • poor abstractions, shallow interfaces

    It’s hard to catch these without understanding context, so I agree a code review meets are helpful and establishing domain owners. But I think you still need PR reviews to document these potential problems





  • My anecdote, granted I’m no Linux master: I recently went into a distro rigamarole, installed openSUSE, Manjaro, etc, before arriving to Mint, because I could not find one that handled my CPU and graphics and drivers setup without significant effort.

    Then I installed Mint (avoiding Ubuntu and its Canonicalness), and setup was very simple and everything worked out of the box. I could run Steam with external GPU without going through many workarounds or setup using nvidia prime and launchers and so forth

    Stylistically I also like cinnamon, but Mint mainly was just so low hassle and simple I have to give it props for that